FangYongs commented on code in PR #25440:
URL: https://github.com/apache/flink/pull/25440#discussion_r1798667849
##########
flink-runtime/src/main/java/org/apache/flink/streaming/api/lineage/DefaultLineageGraph.java:
##########
@@ -33,14 +33,15 @@
@Internal
public class DefaultLineageGraph implements LineageGraph {
@JsonProperty private final List<LineageEdge> lineageEdges;
- @JsonProperty private final List<SourceLineageVertex> sources;
- @JsonProperty private final List<LineageVertex> sinks;
+ @JsonProperty private List<SourceLineageVertex> sources;
+ @JsonProperty private List<LineageVertex> sinks;
+ private final Set<SourceLineageVertex> deduplicatedSources;
Review Comment:
Why not use `Set<SourceLineageVertex>deduplicatedSources` instead of having
one `source` and one `deduplicatedSources`? I find that the `sources` is built
from `deduplicatedSources`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
