[ 
https://issues.apache.org/jira/browse/FLINK-5041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15725665#comment-15725665
 ] 

ASF GitHub Bot commented on FLINK-5041:
---------------------------------------

Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2781#discussion_r91083302
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/migration/runtime/checkpoint/SubtaskState.java
 ---
    @@ -0,0 +1,108 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.migration.runtime.checkpoint;
    +
    +import org.apache.flink.migration.runtime.state.StateHandle;
    +import org.apache.flink.migration.util.SerializedValue;
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
    +
    +import java.io.Serializable;
    +
    +import static org.apache.flink.util.Preconditions.checkNotNull;
    +
    +@Deprecated
    +public class SubtaskState implements Serializable {
    +
    +   private static final long serialVersionUID = -2394696997971923995L;
    +
    +   private static final Logger LOG = 
LoggerFactory.getLogger(SubtaskState.class);
    +
    +   /** The state of the parallel operator */
    +   private final SerializedValue<StateHandle<?>> state;
    +
    +   /**
    +    * The state size. This is also part of the deserialized state handle.
    +    * We store it here in order to not deserialize the state handle when
    +    * gathering stats.
    +    */
    +   private final long stateSize;
    +
    +   /** The duration of the acknowledged (ack timestamp - trigger 
timestamp). */
    +   private final long duration;
    +   
    +   public SubtaskState(
    +                   SerializedValue<StateHandle<?>> state,
    +                   long stateSize,
    +                   long duration) {
    +
    +           this.state = checkNotNull(state, "State");
    +           // Sanity check and don't fail checkpoint because of this.
    +           this.stateSize = stateSize >= 0 ? stateSize : 0;
    +
    +           this.duration = duration;
    +   }
    +
    +   // 
--------------------------------------------------------------------------------------------
    +   
    +   public SerializedValue<StateHandle<?>> getState() {
    +           return state;
    +   }
    +
    +   public long getStateSize() {
    +           return stateSize;
    +   }
    +
    +   public long getDuration() {
    +           return duration;
    +   }
    +
    +   public void discard(ClassLoader userClassLoader) throws Exception {
    +           state.deserializeValue(userClassLoader).discardState();
    --- End diff --
    
    Deactivate this method (see above)


> Implement savepoint backwards compatibility 1.1 -> 1.2
> ------------------------------------------------------
>
>                 Key: FLINK-5041
>                 URL: https://issues.apache.org/jira/browse/FLINK-5041
>             Project: Flink
>          Issue Type: New Feature
>          Components: State Backends, Checkpointing
>    Affects Versions: 1.2.0
>            Reporter: Stefan Richter
>            Assignee: Stefan Richter
>
> This issue tracks the implementation of backwards compatibility between Flink 
> 1.1 and 1.2 releases.
> This task subsumes:
> - Converting old savepoints to new savepoints, including a conversion of 
> state handles to their new replacement.
> - Converting keyed state from old backend implementations to their new 
> counterparts.
> - Converting operator and function state for all changed operators.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to