pawel-big-lebowski commented on code in PR #130:
URL:
https://github.com/apache/flink-connector-kafka/pull/130#discussion_r1802993588
##########
flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/KafkaRecordSerializationSchemaBuilder.java:
##########
@@ -369,5 +377,23 @@ public ProducerRecord<byte[], byte[]> serialize(
value,
headerProvider != null ?
headerProvider.getHeaders(element) : null);
}
+
+ @Override
+ public List<LineageDatasetFacet> getDatasetFacets() {
+ List<LineageDatasetFacet> facets = new ArrayList<>();
+ facets.add(new
KafkaTopicListFacet(Arrays.asList(topicSelector.apply(null))));
+
+ // gets type information from serialize method signature
+
Arrays.stream(this.valueSerializationSchema.getClass().getMethods())
Review Comment:
Checking for `ResultTypeQueryable` first is fair. I've switched to guava
reflection helpers as suggested, but I am not sure if this helps with
`implementation fails if you have some intermediate interface that forward the
type parameter.`. Could you provide example of this issue? Not sure if this is
now covered or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
