[
https://issues.apache.org/jira/browse/FLINK-5220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15725758#comment-15725758
]
ASF GitHub Bot commented on FLINK-5220:
---------------------------------------
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2923#discussion_r91088241
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/rules/util/DataSetCalcConverter.scala
---
@@ -0,0 +1,111 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.api.table.plan.rules.util
+
+import org.apache.calcite.rex.{RexCall, RexInputRef, RexLocalRef, RexNode,
RexShuttle, RexSlot, RexVisitorImpl}
+import org.apache.flink.api.table.plan.nodes.dataset.DataSetCalc
+
+import scala.collection.JavaConversions._
+import scala.collection.mutable
+
+object DataSetCalcConverter {
--- End diff --
Can we make this class `DataSetCalc` independent and only work on
`RexProgram`? Then it can be reused for streaming as well. It could be called
`RexProgramProjectExtractor`.
> Flink SQL projection pushdown
> -----------------------------
>
> Key: FLINK-5220
> URL: https://issues.apache.org/jira/browse/FLINK-5220
> Project: Flink
> Issue Type: Improvement
> Components: Table API & SQL
> Reporter: zhangjing
> Assignee: zhangjing
>
> The jira is to do projection pushdown optimization. Please go forward to the
> the design document for more details.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
