lvyanquan commented on code in PR #3648:
URL: https://github.com/apache/flink-cdc/pull/3648#discussion_r1820005853
##########
flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-paimon/src/main/java/org/apache/flink/cdc/connectors/paimon/sink/v2/PaimonWriterHelper.java:
##########
@@ -111,15 +110,11 @@ private static RecordData.FieldGetter createFieldGetter(
case TIMESTAMP_WITH_TIME_ZONE:
fieldGetter =
row ->
- Timestamp.fromLocalDateTime(
- ZonedDateTime.ofInstant(
-
row.getLocalZonedTimestampData(
-
fieldPos,
-
DataTypeChecks.getPrecision(
-
fieldType))
- .toInstant(),
- zoneId)
- .toLocalDateTime());
+ Timestamp.fromInstant(
Review Comment:
Done fix in Paimon & Kafka connector.
For Doris & Starrocks, they only have datetime type and don't support
timestamp with local time zone, refer to
https://doris.apache.org/zh-CN/docs/1.2/sql-manual/sql-reference/Data-Types/DATETIMEV2/
and https://docs.starrocks.io/docs/sql-reference/data-types/date-types/DATE/,
so we need to convert timestamp_ltz to timestamp using zoneid of database,
Therefore, we do not need to modify the implementation. I added tests here.
And I've picked one fix from https://github.com/apache/flink-cdc/pull/3655.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
