AHeise commented on code in PR #130:
URL:
https://github.com/apache/flink-connector-kafka/pull/130#discussion_r1820444037
##########
flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/lineage/KafkaDatasetIdentifierProvider.java:
##########
@@ -0,0 +1,16 @@
+package org.apache.flink.connector.kafka.lineage;
+
+import
org.apache.flink.connector.kafka.lineage.facets.KafkaDatasetFacet.KafkaDatasetIdentifier;
+
+import java.util.Optional;
+
+/** Contains method which allows extracting topic identifier. */
+public interface KafkaDatasetIdentifierProvider {
Review Comment:
I double-checked and it's not that common of a pattern. It's used only in
```
OperatorCoordinator.java
FileEnumerator.java
DynamicFileEnumerator.java
FileSplitAssigner.java
InternalTimeServiceManager.java
```
So you can just stick to the current approach.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
