xintongsong commented on PR #25516: URL: https://github.com/apache/flink/pull/25516#issuecomment-2451383721
@liangyu-1 Sorry for the late response. I was on a business travel for the past 2 weeks. I'm not entirely sure about this feature. Why do we need thread level audit logs? Wouldn't it be good enough to launch Flink processes with different UGIs? My biggest concern for this PR is that, it invades the common modules (i.e. flink-core & flink-runtime) with Hadoop specific logics. E.g., when generating the `context` string in `startTaskThread()`, it assumes that TM is running on yarn and certain container naming convention is applied. Such logics complicates the system with unnecessary dependencies and assumptions, which makes the code base hard to maintain. I haven't look into whether there's a better way to implement this. But for the current implementation, I'd be negative for merging it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
