SamBarker commented on code in PR #910:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/910#discussion_r1830348754
##########
.github/workflows/ci.yml:
##########
@@ -83,15 +83,33 @@ jobs:
flink-version: "v1_20"
http-client: ${{ matrix.http-client }}
test: test_application_operations.sh
+ java_rutimes:
+ name: Java runtimes smoke test
+ needs: e2e_smoke_test
+ strategy:
+ matrix:
+ http-client: [ "okhttp" ]
+ java-version: [ "11", "17"]
+ flink-version:
+ - "v1_20"
+ - "v1_19"
+ - "v1_18"
+ uses: ./.github/workflows/e2e.yaml
+ with:
+ java-version: ${{ matrix.java-version }}
Review Comment:
Yeah, I had debated making a `flink-tag` parameter but didn't as we would
then have to manually encode the matrix.
>This would show that a JDK17 operator works with a JDK17 flink image, but
not cover the current default operator runtime with a JDK17 flink image.
I'm not convinced that the operator JDK really matters so don't think its
particularly important to have a JDK11 operator deploying a JDK 17 Flink. I can
go that direction if others see it as valuable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
