pnowojski commented on code in PR #25652:
URL: https://github.com/apache/flink/pull/25652#discussion_r1840751043
##########
flink-tests/src/test/java/org/apache/flink/test/misc/JobIDLoggingITCase.java:
##########
@@ -149,9 +149,7 @@ void testJobIDLogging(@InjectClusterClient ClusterClient<?>
clusterClient) throw
sourceCoordinatorLogging,
asList(
"Starting split enumerator.*",
- "Distributing maxAllowedWatermark.*",
- "Source .* registering reader for parallel task.*",
- "Closing SourceCoordinator for source .*"));
Review Comment:
Why did you remove those test cases? In what cases are those "optional"? Can
we change the setup to make them NOT optional? This is effectively removing
test coverage for the JobID logging from the `SourceCoordinator`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
