twalthr commented on code in PR #24256:
URL: https://github.com/apache/flink/pull/24256#discussion_r1837803897
##########
flink-table/flink-sql-parser/src/main/codegen/templates/Parser.jj:
##########
@@ -4629,6 +4642,28 @@ SqlLiteral DateTimeLiteral() :
}
}
+/** Parses a Date/Time constructor function, for example "DATE(1969, 7, 21)"
Review Comment:
check if those work and if yes update
https://nightlies.apache.org/flink/flink-docs-master/docs/dev/table/functions/systemfunctions/#value-construction-functions
##########
flink-table/flink-sql-parser/src/main/codegen/templates/Parser.jj:
##########
@@ -2773,6 +2776,15 @@ SqlNode WindowRange() :
)
}
+/** Parses a QUALIFY clause for SELECT. */
+SqlNode Qualify() :
+{
+ SqlNode e;
+}
+{
+ <QUALIFY> e = Expression(ExprContext.ACCEPT_SUB_QUERY) { return e; }
Review Comment:
check if error message is thrown when using QUALIFY
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
