davidradl commented on code in PR #25647:
URL: https://github.com/apache/flink/pull/25647#discussion_r1851640826
##########
docs/layouts/shortcodes/generated/all_taskmanager_section.html:
##########
@@ -90,7 +90,7 @@
<td><h5>taskmanager.load-balance.mode</h5></td>
<td style="word-wrap: break-word;">NONE</td>
<td><p>Enum</p></td>
- <td>Mode for the load-balance allocation strategy across all
available <code class="highlighter-rouge">TaskManagers</code>.<ul><li>The <code
class="highlighter-rouge">SLOTS</code> mode tries to spread out the slots
evenly across all available <code
class="highlighter-rouge">TaskManagers</code>.</li><li>The <code
class="highlighter-rouge">NONE</code> mode is the default mode without any
specified strategy.</li></ul><br /><br />Possible
values:<ul><li>"NONE"</li><li>"SLOTS"</li></ul></td>
+ <td>Mode for the load-balance allocation strategy across all
available <code class="highlighter-rouge">TaskManagers</code>.<ul><li>The <code
class="highlighter-rouge">SLOTS</code> mode tries to spread out the slots
evenly across all available <code
class="highlighter-rouge">TaskManagers</code>.</li><li>The <code
class="highlighter-rouge">TASKS</code> mode tries to schedule evenly all tasks
based on its' number across all available <code
class="highlighter-rouge">TaskManagers</code>. Note: Currently, enabling this
parameter can only achieve the balancing effect of the slot level dimension of
<code class="highlighter-rouge">DefaultScheduler</code>.</li><li>The <code
class="highlighter-rouge">NONE</code> mode is the default mode without any
specified strategy.</li></ul><br /><br />Possible
values:<ul><li>"NONE"</li><li>"SLOTS"</li><li>"TASKS"</li></ul></td>
Review Comment:
I am not sure what this sentence means - it would be really useful to have a
diagram, and maybe an example showing the SLOT and TASK modes and how they
differ.
It would also be useful to detail why you would choose TASK mode of SLOT
mode.
I was looking for more information in the Jira - it should point to the Flip
.
I see some of the conversations in the PR as to why this might be needed.
Could we summarize these considerations in the docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
