JunRuiLee commented on code in PR #25674:
URL: https://github.com/apache/flink/pull/25674#discussion_r1855450279
##########
flink-kubernetes/src/main/java/org/apache/flink/kubernetes/entrypoint/KubernetesApplicationClusterEntrypoint.java:
##########
@@ -146,14 +148,15 @@ private static ArtifactFetchManager.Result
fetchArtifacts(Configuration configur
String targetDir = generateJarDir(configuration);
ArtifactFetchManager fetchMgr = new
ArtifactFetchManager(configuration, targetDir);
- List<String> uris = configuration.get(PipelineOptions.JARS);
- checkArgument(uris.size() == 1, "Should only have one jar");
+ List<String> uris =
+
configuration.getOptional(PipelineOptions.JARS).orElse(Collections.emptyList());
+ checkArgument(uris.size() <= 1, "Should only have at most one
jar");
Review Comment:
How about handling the jar file requirements for SQL jobs in the same way as
we do for Python jobs?
For example, by introducing a method like
PackagedProgramUtils.isSqlScript(String entryPointClassName)?
And doing the same for yarn as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
