tamirsagi commented on PR #5: URL: https://github.com/apache/flink-connector-jdbc/pull/5#issuecomment-2515279589
> @tamirsagi Is this fix still needed? Or the one i send in? #75 ? if you are asking whether its still relevant, then yes. yours is similar. yet, I'd wrap connectionProvider with try because it's cleaner & safer. + I don't see any reason to store an exception to flushException during #close. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
