reswqa commented on code in PR #25729:
URL: https://github.com/apache/flink/pull/25729#discussion_r1871211930
##########
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/nodes/physical/batch/BatchPhysicalLookupJoin.scala:
##########
@@ -42,15 +43,22 @@ class BatchPhysicalLookupJoin(
temporalTable: RelOptTable,
tableCalcProgram: Option[RexProgram],
joinInfo: JoinInfo,
- joinType: JoinRelType)
+ joinType: JoinRelType,
+ lookupHint: Option[RelHint] = Option.empty,
+ enableLookupShuffle: Boolean = false,
+ preferCustomShuffle: Boolean = false)
Review Comment:
enableLookupShuffle means user tend to shuffle input stream,
preferCustomShuffle means dim table prefer custom partitioners to hash
partitioner. These are two concepts that are not exactly equivalent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
