davidradl commented on code in PR #25763:
URL: https://github.com/apache/flink/pull/25763#discussion_r1875825715
##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/BuiltInFunctionDefinitions.java:
##########
@@ -2332,14 +2332,24 @@ ANY, and(logical(LogicalTypeRoot.BOOLEAN), LITERAL)
public static final BuiltInFunctionDefinition TO_TIMESTAMP_LTZ =
BuiltInFunctionDefinition.newBuilder()
- .name("toTimestampLtz")
- .sqlName("TO_TIMESTAMP_LTZ")
+ .name("TO_TIMESTAMP_LTZ")
Review Comment:
looks like we are changing the name of an existing function - I assume this
will impact migration. Don't we need to deprecate the old function and add the
new one with the new name? And then put thjis in the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
