[ 
https://issues.apache.org/jira/browse/FLINK-36885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dawid Wysakowicz updated FLINK-36885:
-------------------------------------
    Affects Version/s: 1.20.0
                       2.0.0

> Multiple tests are incorrectly migrated to JUnit 5
> --------------------------------------------------
>
>                 Key: FLINK-36885
>                 URL: https://issues.apache.org/jira/browse/FLINK-36885
>             Project: Flink
>          Issue Type: Bug
>    Affects Versions: 2.0.0, 1.20.0
>            Reporter: Dawid Wysakowicz
>            Priority: Major
>
> I observed on a few occasions already that parameterized tests were not 
> migrated correctly to JUnit 5. 
> Take JavaCatalogTableTest for example: 
> https://github.com/apache/flink/commit/1fbe223a5d7b9232d58f471ae620306b9dad58ea
> The JUnit 5 infrastructure requires that the name of the parameter must match 
> exactly the name in the string of {{Parameters}} annotation. That was not the 
> case in this PR. The parameter name is {{isStreamingMode}} while the string 
> constant is {{streamingMode}} which effectively meant the test was not 
> parameterized.
> It would be good to check all the cases where the migration was performed and 
> fix where it was done incorrectly.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to