xuyangzhong commented on code in PR #23980:
URL: https://github.com/apache/flink/pull/23980#discussion_r1881240233
##########
flink-table/flink-table-api-scala-bridge/src/test/scala/org/apache/flink/table/api/bridge/scala/internal/StreamTableEnvironmentImplTest.scala:
##########
@@ -48,8 +48,9 @@ class StreamTableEnvironmentImplTest {
val table = tEnv.fromDataStream(elements)
tEnv.toDataStream(table)
-
assertThat(tEnv.getConfig.getMinIdleStateRetentionTime).isEqualTo(retention.toMillis)
-
assertThat(tEnv.getConfig.getMaxIdleStateRetentionTime).isEqualTo(retention.toMillis
* 3 / 2)
+
assertThat(tEnv.getConfig.getIdleStateRetention.toMillis).isEqualTo(retention.toMillis)
+ assertThat(tEnv.getConfig.getIdleStateRetention.toMillis * 3 / 2)
Review Comment:
nit: It seems that this assertion can be removed:
```
assertThat(tEnv.getConfig.getIdleStateRetention.toMillis * 3 / 2)...
```
##########
flink-table/flink-table-api-scala-bridge/src/test/scala/org/apache/flink/table/api/bridge/scala/internal/StreamTableEnvironmentImplTest.scala:
##########
@@ -63,8 +64,9 @@ class StreamTableEnvironmentImplTest {
val table = tEnv.fromDataStream(elements)
tEnv.toRetractStream[Row](table)
-
assertThat(tEnv.getConfig.getMinIdleStateRetentionTime).isEqualTo(retention.toMillis)
-
assertThat(tEnv.getConfig.getMaxIdleStateRetentionTime).isEqualTo(retention.toMillis
* 3 / 2)
+
assertThat(tEnv.getConfig.getIdleStateRetention.toMillis).isEqualTo(retention.toMillis)
+ assertThat(tEnv.getConfig.getIdleStateRetention.toMillis * 3 / 2)
Review Comment:
ditto
##########
flink-python/pyflink/table/table_config.py:
##########
@@ -239,7 +239,7 @@ def get_min_idle_state_retention_time(self) -> int:
:return: The minimum time until state which was not updated will be
retained.
"""
- return self._j_table_config.getMinIdleStateRetentionTime()
+ return self._j_table_config.getIdleStateRetention().toMillis()
Review Comment:
I think these python methods `get_min_idle_state_retention_time` and
`get_max_idle_state_retention_time` can also be removed because they have been
tagged `deprecated` in comments. cc @HuangXingBo can you help to double check
it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
