snuyanzin commented on code in PR #25763:
URL: https://github.com/apache/flink/pull/25763#discussion_r1881885358
##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/utils/DateTimeUtils.java:
##########
@@ -386,6 +406,18 @@ public static TimestampData toTimestampData(DecimalData v,
int precision) {
}
}
+ public static TimestampData toTimestampData(long epoch) {
+ return toTimestampData(epoch, 3);
+ }
+
+ public static TimestampData toTimestampData(double epoch) {
+ return toTimestampData(epoch, 3);
+ }
+
+ public static TimestampData toTimestampData(DecimalData epoch) {
+ return toTimestampData(epoch, 3);
+ }
+
Review Comment:
from any user outside of `TO_TIMESTAMP_LTZ` 3 here is a magic number.
I would suggest to have such calls only in your toTimestampLtzFunction class
and don't put them here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
