snuyanzin commented on code in PR #25791:
URL: https://github.com/apache/flink/pull/25791#discussion_r1881898765
##########
flink-table/flink-table-api-java/src/test/java/org/apache/flink/table/expressions/ExpressionSerializationTest.java:
##########
@@ -172,13 +172,13 @@ public static Stream<TestSpec> testData() {
.expectStr("POSITION(`f0` IN 'ABC')"),
TestSpec.forExpr($("f0").trim("ABC"))
.withField("f0", DataTypes.STRING())
- .expectStr("TRIM BOTH 'ABC' FROM `f0`"),
+ .expectStr("TRIM(BOTH 'ABC' FROM `f0`)"),
TestSpec.forExpr($("f0").trimLeading("ABC"))
.withField("f0", DataTypes.STRING())
- .expectStr("TRIM LEADING 'ABC' FROM `f0`"),
+ .expectStr("TRIM(LEADING 'ABC' FROM `f0`)"),
TestSpec.forExpr($("f0").trimTrailing("ABC"))
.withField("f0", DataTypes.STRING())
- .expectStr("TRIM TRAILING 'ABC' FROM `f0`"),
+ .expectStr("TRIM(TRAILING 'ABC' FROM `f0`)"),
TestSpec.forExpr($("f0").overlay("ABC", 2))
Review Comment:
there are sql and table api
which of them are you talking about?
sql is in left column in contains
```sql
TRIM([ BOTH | LEADING | TRAILING ] string1 FROM string2)
```
table api among others contains what you've mentioned
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
