davidradl commented on code in PR #25788:
URL: https://github.com/apache/flink/pull/25788#discussion_r1882245040
##########
flink-runtime/src/main/java/org/apache/flink/runtime/rest/RestClient.java:
##########
@@ -317,7 +337,7 @@ private CompletableFuture<Void> shutdownInternally(Duration
timeout) {
LOG.debug("Shutting down rest endpoint.");
if (bootstrap != null) {
- if (bootstrap.config().group() != null) {
+ if (bootstrap.config().group() != null &&
useInternalEventLoopGroup) {
Review Comment:
why does this if have `&& useInternalEventLoopGroup`? I would assume we want
to pass the group through whether we have an internal group or whether one has
been supplied.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
