snuyanzin commented on code in PR #143: URL: https://github.com/apache/flink-connector-jdbc/pull/143#discussion_r1883614070
########## flink-connector-jdbc-postgres/src/main/java/org/apache/flink/connector/jdbc/postgres/database/dialect/CompatiblePostgresDialectConverter.java: ########## @@ -18,11 +18,11 @@ package org.apache.flink.connector.jdbc.postgres.database.dialect; -import org.apache.flink.annotation.PublicEvolving; +import org.apache.flink.annotation.Internal; import org.apache.flink.table.types.logical.RowType; /** JDBC converter for PostgreSQL compatible databases. */ -@PublicEvolving +@Internal Review Comment: >I can add the exception if you still believe that a FLIP is necessary and focus the discussion solely on that change. I believe this will not impact the rest of the PR. would be great. Agree, rest of the PR is more or less ok (I did only a brief look, will look again a bit later) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
