mxm commented on code in PR #921:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/921#discussion_r1884219220
##########
flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingMetricEvaluator.java:
##########
@@ -296,8 +297,16 @@ protected static void computeProcessingRateThresholds(
upperUtilization = 1.0;
lowerUtilization = 0.0;
} else {
- upperUtilization = targetUtilization + utilizationBoundary;
- lowerUtilization = targetUtilization - utilizationBoundary;
+ if (conf.getOptional(UTILIZATION_MAX).isPresent()
+ || conf.getOptional(UTILIZATION_MIN).isPresent()
+ ||
conf.getOptional(TARGET_UTILIZATION_BOUNDARY).isEmpty()) {
+ upperUtilization = conf.get(UTILIZATION_MAX);
+ lowerUtilization = conf.get(UTILIZATION_MIN);
Review Comment:
+1 for not having static defaults for the new options because that would be
confusing to users.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
