JunRuiLee commented on code in PR #25798:
URL: https://github.com/apache/flink/pull/25798#discussion_r1886070318
##########
flink-runtime/src/main/java/org/apache/flink/runtime/execution/ExecutionState.java:
##########
@@ -70,6 +70,8 @@ public enum ExecutionState {
RECONCILING,
+ PENDING,
Review Comment:
How about handle `pending-operators` in the
`JobDetailsHandler#createJobDetailsInfo`. This way, we wouldn't need to
introduce any meaningless statuses to a common enum class.
##########
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java:
##########
@@ -101,6 +102,8 @@ void enableCheckpointing(
void setJsonPlan(String jsonPlan);
+ void setJsonStreamGraph(JsonStreamGraph jsonStreamGraph);
Review Comment:
I prefer to retrieve the JSON of the stream graph from
`ExecutionPlanSchedulingContext`. For example, we could add a method
`getJsonStreamGraph` in `ExecutionPlanSchedulingContext`. This context will
return the JSON held by `AdaptiveGraphManager`. When the stream graph is
updated by the `DefaultStreamGraphContext`, the AdaptiveGraphManager should
update this JSON.
With this update, we could avoid manually passing this JSON to the execution
graph and keep this change simple.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
