davidradl commented on code in PR #25810:
URL: https://github.com/apache/flink/pull/25810#discussion_r1888663499
##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/TableEnvironmentImpl.java:
##########
@@ -661,6 +673,18 @@ public boolean dropTemporaryView(String path) {
}
}
+ @Override
+ public boolean dropView(String path) {
+ UnresolvedIdentifier unresolvedIdentifier =
getParser().parseIdentifier(path);
+ ObjectIdentifier identifier =
catalogManager.qualifyIdentifier(unresolvedIdentifier);
+ try {
+ catalogManager.dropView(identifier, false);
+ return true;
+ } catch (ValidationException e) {
+ return false;
Review Comment:
Yes you are right it is not a regression - still I think it is worth a log
entry when there is an Exception and it returns false; Though I see all the
other `return false `do not log - so we should add logging to each of them if
we do this one .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
