snuyanzin commented on code in PR #25810:
URL: https://github.com/apache/flink/pull/25810#discussion_r1890613871
##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/CatalogManager.java:
##########
@@ -1350,6 +1356,7 @@ private void dropTableInternal(
objectIdentifier,
ignoreIfNotExists,
"DropTable");
+ return true;
Review Comment:
I think you mean this kind of check
```java
final Optional<CatalogBaseTable> resultOpt =
getUnresolvedTable(objectIdentifier);
if (resultOpt.isPresent() && filter.test(resultOpt.get())) {
...
}
```
which is already happening starting line 1331
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
