yiyutian1 commented on code in PR #25763:
URL: https://github.com/apache/flink/pull/25763#discussion_r1891223195
##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/BuiltInFunctionDefinitions.java:
##########
@@ -2332,14 +2332,24 @@ ANY, and(logical(LogicalTypeRoot.BOOLEAN), LITERAL)
public static final BuiltInFunctionDefinition TO_TIMESTAMP_LTZ =
BuiltInFunctionDefinition.newBuilder()
- .name("toTimestampLtz")
- .sqlName("TO_TIMESTAMP_LTZ")
+ .name("TO_TIMESTAMP_LTZ")
Review Comment:
After some research, the new Java stack only has one "name", eg.
[here](https://github.com/apache/flink/blob/01a2b28160f70a12d7200790acde53a9e910339a/flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/BuiltInFunctionDefinitions.java#L237).
We are not changing the api name, the new stack is able to recognize the
same api name as before
[here](https://github.com/apache/flink/pull/25763/files#diff-d2ce68433255086dfdc898b9fd6636186044115a1280d39d6d04ebfd99933e94R377-R422).
Verified the compatibility by:
1. existing Scala tests pass
2. new Java tests pass
3. ran that the compiled physical execution plan are identical, with and
without this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
