jnh5y commented on code in PR #25763:
URL: https://github.com/apache/flink/pull/25763#discussion_r1893225419
##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/utils/DateTimeUtils.java:
##########
@@ -424,8 +424,12 @@ public static TimestampData parseTimestampData(String
dateStr, int precision, Ti
}
public static TimestampData parseTimestampData(String dateStr, String
format) {
- DateTimeFormatter formatter = DATETIME_FORMATTER_CACHE.get(format);
-
Review Comment:
Nice! This also makes sense to catch the IllegalArgumentException / parse
errors!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
