JunRuiLee commented on code in PR #25798:
URL: https://github.com/apache/flink/pull/25798#discussion_r1893743687
##########
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/job/JobDetailsHandler.java:
##########
@@ -141,6 +142,11 @@ private static JobDetailsInfo createJobDetailsInfo(
executionState,
jobVerticesPerState[executionState.ordinal()]);
}
+ JobPlanInfo.RawJson streamGraphJson = null;
+ if
(!StringUtils.isNullOrWhitespaceOnly(executionGraph.getStreamGraphJson())) {
Review Comment:
I think isNullOrWhitespaceOnly will not throw an exception if the string is
null.
If we want to perform a safety check, we should evaluate the state and throw
an exception if it is not as expected.
So here maybe checkNotNull() is better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
