[ 
https://issues.apache.org/jira/browse/FLINK-5113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15735513#comment-15735513
 ] 

ASF GitHub Bot commented on FLINK-5113:
---------------------------------------

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2939#discussion_r91722459
  
    --- Diff: 
flink-tests/src/test/java/org/apache/flink/test/classloading/jar/CheckpointedStreamingProgram.java
 ---
    @@ -57,7 +59,7 @@ public static void main(String[] args) throws Exception {
     
     
        // with Checkpoining
    -   public static class SimpleStringGenerator implements 
SourceFunction<String>, Checkpointed<Integer> {
    --- End diff --
    
    I understand why you did not replace ´Checkpointed` with a different 
interface, but this technically changes the test. If a function can still 
implement these interfaces without doing anything within snapshot/restore, then 
we should cover this with tests.


> Make all Testing Functions implement CheckpointedFunction Interface.
> --------------------------------------------------------------------
>
>                 Key: FLINK-5113
>                 URL: https://issues.apache.org/jira/browse/FLINK-5113
>             Project: Flink
>          Issue Type: Improvement
>          Components: DataStream API
>    Affects Versions: 1.2.0
>            Reporter: Kostas Kloudas
>            Assignee: Kostas Kloudas
>             Fix For: 1.2.0
>
>
> Currently stateful functions implement the (old) Checkpointed interface.
> This is issue aims at porting all these function to the new 
> CheckpointedFunction interface, so that they can leverage the new 
> capabilities by it. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to