pltbkd commented on PR #24916: URL: https://github.com/apache/flink/pull/24916#issuecomment-2561698566
Hi @X-czh , thanks for this PR. It's overall LGTM, but I noticed some relating issues to this topic (built-in collection serializer) and this PR: 1. MapSerializer does not support null key, which means it needs an enhancement like this as well. 2. List, map and set serializers are all not support that the collection itself is null. This can be troublesome since some internal serializers of container types are not supporting null content, among which the most commonly used is StreamElementSerializer. To use these serializers as defaults safely, we have to: i) make these serializers support null collections, or ii) check all built-in serializers to ensure they properly handle null elements without invoking the value serializer. What do you think about these issues? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
