Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/2977
Thanks for working on this @mtunique!
I would like to suggest the following. All test classes in
`./test/java/org/apache/flink/api/java/batch/table` are split into a validation
and a plan test class. All tests are implemented in Scala and moved to the
`./test/scala/` directory.
- The validation tests contain the test methods which check for failing
validation. These tests are all unit tests and are named like
`CalcValidationTest`.
- The plan test compare the logical plans of the string Table API and the
expression Table API. These are also unit tests and named like `CalcPlanTest`.
I would not merge these tests with the execution tests of the expression Table
API but keep them separate.
The file `./test/java/org/apache/flink/api/java/batch/ExplainTest` can be
removed. It checks exactly the same as the Scala version of this test.
What do you think?
Best, Fabian
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
