davidradl commented on code in PR #25770:
URL: https://github.com/apache/flink/pull/25770#discussion_r1901668640
##########
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/AdaptiveScheduler.java:
##########
@@ -1266,7 +1269,12 @@ public void goToRestarting(
forcedRestart,
userCodeClassLoader,
failureCollection));
- numRestarts++;
+
Review Comment:
Prior to the change the numRestarts was all the restarts (including the
rescales). After the fix, this metric now only reports restarts that were not
rescales. `numRestarts` implies all restarts to me. I suggest we always
increment `numRestarts` as before, then add
```
if (failureCollection.isEmpty()) {
numRescales++;
}
```
We would need to amend the documentation accordingly to say numRestarts
includes all restarts including rescales.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
