davidradl commented on code in PR #25763:
URL: https://github.com/apache/flink/pull/25763#discussion_r1905566167
##########
flink-python/pyflink/table/tests/test_expression.py:
##########
@@ -285,7 +285,14 @@ def test_expressions(self):
self.assertEqual("toDate('2018-03-18')", str(to_date('2018-03-18')))
self.assertEqual("toDate('2018-03-18', 'yyyy-MM-dd')",
str(to_date('2018-03-18', 'yyyy-MM-dd')))
- self.assertEqual('toTimestampLtz(123, 0)', str(to_timestamp_ltz(123,
0)))
Review Comment:
some negative tests would be good. For example with precision 10, would it
give an error relating to format or precision
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
