Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2961#discussion_r91906988
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/table.scala
 ---
    @@ -881,24 +883,21 @@ class GroupWindowedTable(
         * }}}
         */
       def select(fields: Expression*): Table = {
    --- End diff --
    
    Not sure, I would like to avoid a solution where projections for aggregates 
are injected at different locations in the code, i.e., injecting a projection 
before validation for non-windowed aggregates and after validation (or during 
optimization) for windowed aggregates. I think it would be better to have this 
consistent.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to