gyfora commented on code in PR #25656:
URL: https://github.com/apache/flink/pull/25656#discussion_r1906994019
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/runtime/stream/sql/FunctionITCase.java:
##########
@@ -1542,6 +1542,21 @@ void testUsingAddJar() throws Exception {
"drop function lowerUdf");
}
+ @Test
+ void testUsingAddJarWithCheckpointing() throws Exception {
+ env().enableCheckpointing(100);
+ tEnv().executeSql(String.format("ADD JAR '%s'", jarPath));
+ ClassLoader contextClassLoader =
Thread.currentThread().getContextClassLoader();
+ testUserDefinedFunctionByUsingJar(
+ env ->
+ env.executeSql(
+ String.format(
+ "create function lowerUdf as '%s'
LANGUAGE JAVA",
+ udfClassName)),
+ "drop function lowerUdf");
+
assertThat(contextClassLoader.equals(Thread.currentThread().getContextClassLoader()));
+ }
Review Comment:
@ammu20-dev @snuyanzin
If this issue exists for several Flink versions (from 1.16) then we should
not introduce large and risky changes in a patch version to fix it. Especially
if this is already fixed in a safe tested way for Flink 2.0.
In this particular case especially that the scope of the backport is much
larger than the original problem, my suggestion is to not fix this for 1.20 and
before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
