davidradl commented on code in PR #25763:
URL: https://github.com/apache/flink/pull/25763#discussion_r1907215587
##########
flink-python/pyflink/table/expressions.py:
##########
@@ -306,19 +306,38 @@ def to_timestamp(timestamp_str: Union[str,
Expression[str]],
return _binary_op("toTimestamp", timestamp_str, format)
-def to_timestamp_ltz(numeric_epoch_time, precision) -> Expression:
+def to_timestamp_ltz(*args) -> Expression:
"""
- Converts a numeric type epoch time to TIMESTAMP_LTZ.
+ Converts a value to a timestamp with local time zone.
- The supported precision is 0 or 3:
- 0 means the numericEpochTime is in second.
- 3 means the numericEpochTime is in millisecond.
+ Supported functions:
+ 1. to_timestamp_ltz(Numeric) -> DataTypes.TIMESTAMP_LTZ
+ 2. to_timestamp_ltz(Numeric, Integer) -> DataTypes.TIMESTAMP_LTZ
Review Comment:
Thanks @yiyutian1 I was thinking about this and wonder would it be clearer
not to use `args*` but have the methods explicitly with parameters - then it is
obvious from the function prototypes what the parameters are and we can
document appropriately similar to JAVA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
