reswqa commented on code in PR #25961: URL: https://github.com/apache/flink/pull/25961#discussion_r1914392525
########## flink-datastream/src/main/java/org/apache/flink/datastream/impl/builtin/BuiltinJoinFuncs.java: ########## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.datastream.impl.builtin; + +import org.apache.flink.datastream.api.builtin.BuiltinFuncs; +import org.apache.flink.datastream.api.extension.join.JoinFunction; +import org.apache.flink.datastream.api.extension.join.JoinType; +import org.apache.flink.datastream.api.function.TwoInputNonBroadcastStreamProcessFunction; +import org.apache.flink.datastream.impl.extension.join.operators.TwoInputJoinProcessFunction; + +/** Join-related implementations in {@link BuiltinFuncs}. */ +public class BuiltinJoinFuncs { + + /** + * Wrap the JoinFunction and INNER JoinType within a ProcessFunction to perform the Join Review Comment: ```suggestion * Wrap the JoinFunction and JoinType within a ProcessFunction to perform the Join ``` ########## flink-datastream/src/main/java/org/apache/flink/datastream/impl/extension/join/operators/TwoInputJoinProcessFunction.java: ########## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.datastream.impl.extension.join.operators; + +import org.apache.flink.datastream.api.common.Collector; +import org.apache.flink.datastream.api.context.PartitionedContext; +import org.apache.flink.datastream.api.extension.join.JoinFunction; +import org.apache.flink.datastream.api.extension.join.JoinType; +import org.apache.flink.datastream.api.function.TwoInputNonBroadcastStreamProcessFunction; + +/** + * Wrap the user-defined {@link JoinFunction} as {@link TwoInputNonBroadcastStreamProcessFunction} + * to execute the Join operation within Join extension. + */ +public class TwoInputJoinProcessFunction<IN1, IN2, OUT> + implements TwoInputNonBroadcastStreamProcessFunction<IN1, IN2, OUT> { + + private final JoinFunction<IN1, IN2, OUT> joinFunction; + + private final JoinType joinType; + + public TwoInputJoinProcessFunction( + JoinFunction<IN1, IN2, OUT> joinFunction, JoinType joinType) { + this.joinFunction = joinFunction; + this.joinType = joinType; + } + + @Override + public void processRecordFromFirstInput( + IN1 record, Collector<OUT> output, PartitionedContext ctx) throws Exception {} Review Comment: Raw use of parameterized class 'PartitionedContext' ########## flink-datastream/src/main/java/org/apache/flink/datastream/impl/extension/join/operators/TwoInputJoinProcessFunction.java: ########## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.datastream.impl.extension.join.operators; + +import org.apache.flink.datastream.api.common.Collector; +import org.apache.flink.datastream.api.context.PartitionedContext; +import org.apache.flink.datastream.api.extension.join.JoinFunction; +import org.apache.flink.datastream.api.extension.join.JoinType; +import org.apache.flink.datastream.api.function.TwoInputNonBroadcastStreamProcessFunction; + +/** + * Wrap the user-defined {@link JoinFunction} as {@link TwoInputNonBroadcastStreamProcessFunction} + * to execute the Join operation within Join extension. + */ +public class TwoInputJoinProcessFunction<IN1, IN2, OUT> + implements TwoInputNonBroadcastStreamProcessFunction<IN1, IN2, OUT> { Review Comment: Why broadcast stream is not supported? ########## flink-datastream/src/main/java/org/apache/flink/datastream/impl/extension/join/operators/TwoInputJoinProcessFunction.java: ########## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.datastream.impl.extension.join.operators; + +import org.apache.flink.datastream.api.common.Collector; +import org.apache.flink.datastream.api.context.PartitionedContext; +import org.apache.flink.datastream.api.extension.join.JoinFunction; +import org.apache.flink.datastream.api.extension.join.JoinType; +import org.apache.flink.datastream.api.function.TwoInputNonBroadcastStreamProcessFunction; + +/** + * Wrap the user-defined {@link JoinFunction} as {@link TwoInputNonBroadcastStreamProcessFunction} + * to execute the Join operation within Join extension. + */ +public class TwoInputJoinProcessFunction<IN1, IN2, OUT> + implements TwoInputNonBroadcastStreamProcessFunction<IN1, IN2, OUT> { + + private final JoinFunction<IN1, IN2, OUT> joinFunction; + + private final JoinType joinType; + + public TwoInputJoinProcessFunction( + JoinFunction<IN1, IN2, OUT> joinFunction, JoinType joinType) { + this.joinFunction = joinFunction; + this.joinType = joinType; + } + + @Override + public void processRecordFromFirstInput( + IN1 record, Collector<OUT> output, PartitionedContext ctx) throws Exception {} + + @Override + public void processRecordFromSecondInput( + IN2 record, Collector<OUT> output, PartitionedContext ctx) throws Exception {} Review Comment: Raw use of parameterized class 'PartitionedContext' ########## flink-datastream-api/src/main/java/org/apache/flink/datastream/api/extension/join/JoinType.java: ########## @@ -0,0 +1,27 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.datastream.api.extension.join; + +import org.apache.flink.annotation.Experimental; + +/** The type/algorithm of join operation. */ Review Comment: Add the reason why we don't support outer join for now in the java doc. ########## flink-tests/src/test/java/org/apache/flink/test/streaming/api/datastream/JoinITCase.java: ########## @@ -0,0 +1,389 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.test.streaming.api.datastream; + +import org.apache.flink.api.connector.dsv2.DataStreamV2SourceUtils; +import org.apache.flink.api.connector.dsv2.WrappedSink; +import org.apache.flink.api.connector.sink2.Sink; +import org.apache.flink.api.connector.sink2.SinkWriter; +import org.apache.flink.api.connector.sink2.WriterInitContext; +import org.apache.flink.api.java.functions.KeySelector; +import org.apache.flink.datastream.api.ExecutionEnvironment; +import org.apache.flink.datastream.api.builtin.BuiltinFuncs; +import org.apache.flink.datastream.api.common.Collector; +import org.apache.flink.datastream.api.context.PartitionedContext; +import org.apache.flink.datastream.api.context.RuntimeContext; +import org.apache.flink.datastream.api.extension.join.JoinFunction; +import org.apache.flink.datastream.api.extension.join.JoinType; +import org.apache.flink.datastream.api.function.OneInputStreamProcessFunction; +import org.apache.flink.datastream.api.function.TwoInputNonBroadcastStreamProcessFunction; +import org.apache.flink.datastream.api.stream.KeyedPartitionStream; +import org.apache.flink.datastream.api.stream.NonKeyedPartitionStream; + +import org.apache.flink.shaded.guava32.com.google.common.collect.Lists; Review Comment: Could we avoid the use of guava? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
