leonardBang commented on code in PR #3860:
URL: https://github.com/apache/flink-cdc/pull/3860#discussion_r1915948137
##########
flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-elasticsearch/src/test/java/org/apache/flink/cdc/connectors/elasticsearch/sink/Elasticsearch7DataSinkITCaseTest.java:
##########
@@ -137,7 +137,7 @@ public void testElasticsearchInsertAndDelete() throws
Exception {
@Test
public void testElasticsearchAddColumn() throws Exception {
TableId tableId = TableId.tableId("default", "schema", "table");
- List<Event> events =
ElasticsearchTestUtils.createTestEventsWithAddColumn(tableId); // 使用工具类
Review Comment:
could you help check all Chinese note?
##########
flink-cdc-cli/src/test/resources/log4j2-test.properties:
##########
@@ -13,7 +13,7 @@
# Set root logger level to OFF to not flood build logs
# set manually to INFO for debugging purposes
-rootLogger.level = INFO
+rootLogger.level = OFF
Review Comment:
How about changing the level to ERROR so that we can see some exception
message in log?
##########
flink-cdc-runtime/src/test/java/org/apache/flink/cdc/runtime/serializer/SerializerTestBase.java:
##########
@@ -265,8 +264,7 @@ void testSerializeIndividually() {
assertTrue("Trailing data available after deserialization.",
in.available() == 0);
}
} catch (Exception e) {
- System.err.println(e.getMessage());
Review Comment:
Could you check all system output? We should use LOGGER instead of System
output.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
