[ 
https://issues.apache.org/jira/browse/FLINK-5245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15743017#comment-15743017
 ] 

Greg Hogan commented on FLINK-5245:
-----------------------------------

In addition to being useful the API must promote efficiency and best practices. 
The add/remove methods are lacking since 1) the vertices/edges must be known a 
priori, 2) the methods are not scalable, and 3) users may have the idea to call 
these methods inside a local for loop.

We should rethink the API as features are added. I would like to see 
`getUndirected()` and `getDegrees()` reimplemented.

I like that we're adding a lot of bipartite graph functionality. How can we 
best avoid duplication of code? Perhaps Edge should be a specialization of 
BipartiteEdge and Graph a specialization of BipartiteGraph (the names would 
change, of course). Implementing some algorithms (such as redundancy from the 
two-mode paper) may help answer these questions.

> Add support for BipartiteGraph mutations
> ----------------------------------------
>
>                 Key: FLINK-5245
>                 URL: https://issues.apache.org/jira/browse/FLINK-5245
>             Project: Flink
>          Issue Type: Improvement
>          Components: Gelly
>            Reporter: Ivan Mushketyk
>            Assignee: Ivan Mushketyk
>
> Implement methods for adding and removing vertices and edges similarly to 
> Graph class.
> Depends on https://issues.apache.org/jira/browse/FLINK-2254



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to