davidradl commented on code in PR #25944:
URL: https://github.com/apache/flink/pull/25944#discussion_r1916962966
##########
flink-kubernetes/src/main/java/org/apache/flink/kubernetes/configuration/KubernetesConfigOptions.java:
##########
@@ -510,6 +510,23 @@ public class KubernetesConfigOptions {
"Whether to enable HostNetwork mode. "
+ "The HostNetwork allows the pod could
use the node network namespace instead of the individual pod network namespace.
Please note that the JobManager service account should have the permission to
update Kubernetes service.");
+
+
+ public static final ConfigOption<String> KUBERNETES_LOG_VOLUME_HOSTPATH =
+ key("kubernetes.log.volume.hostpath")
+ .stringType()
+ .defaultValue("/apps/log/flink")
+ .withDescription("flink host machine log path");
+
+
+ public static final ConfigOption<String>
KUBERNETES_LOG_VOLUMES_MOUNT_MOUNTPATH =
+ key("kubernetes.log.volumemounts.mountpath")
Review Comment:
I am not a k8s expert. I have some basic questions:
- we should document these new config options.
- are there not issues in supplying default locations to write logs in a PR,
as suddenly there will be a lot of data written to locations that was
previously not written. I would assume that /apps/log/flink and /opt/flink/log
are folders and could get full - so size would need to be managed; maybe having
criteria to delete / archive older logs. If there is new management required of
these logs, then the considerations should be documented.
- It would be helpful to describe in the Jira in more detail what the
problem is and how this fixes it.
- what is the life cycle of HostPathVolumeSource - it it associated
with the pod, so are we trying to keep
logs that would have disappeared with the container, in storage
associated with the pod and we would
lose the logs if the pods die.
- I wonder what the impact is of enabling this for all containers after this
PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
