lvyanquan commented on code in PR #3856:
URL: https://github.com/apache/flink-cdc/pull/3856#discussion_r1918122160
##########
flink-cdc-connect/flink-cdc-source-connectors/flink-cdc-base/src/main/java/org/apache/flink/cdc/connectors/base/source/assigner/splitter/JdbcSourceChunkSplitter.java:
##########
@@ -498,7 +498,7 @@ private List<ChunkRange> splitUnevenlySizedChunks(
chunkEnd = nextChunkEnd(jdbc, chunkEnd, tableId, splitColumn, max,
chunkSize);
}
// add the ending split
- splits.add(ChunkRange.of(chunkStart, null));
+ splits.add(0, ChunkRange.of(chunkStart, null));
Review Comment:
Good optimization, so both the largest and smallest unbounded chunks are
completed in the first two splits, and subsequent chunks are bounded size.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
