snuyanzin commented on code in PR #25646:
URL: https://github.com/apache/flink/pull/25646#discussion_r1920477471
##########
flink-python/pom.xml:
##########
@@ -377,6 +377,12 @@ under the License.
<artifactId>commons-lang3</artifactId>
</dependency>
+ <dependency>
+ <groupId>com.fasterxml.jackson.datatype</groupId>
Review Comment:
@davidradl what made you thinking we use ?
>I notice that
https://github.com/FasterXML/jackson-datatype-jdk8?tab=readme-ov-file is
deprecated
If you look at https://github.com/FasterXML/jackson-modules-java8
especially in README at this section
https://github.com/FasterXML/jackson-modules-java8
there is
>To include modules, you use some or all of:
```xml
<!-- Java 8 Datatypes -->
<dependency>
<groupId>com.fasterxml.jackson.datatype</groupId>
<artifactId>jackson-datatype-jdk8</artifactId>
</dependency>
```
https://github.com/FasterXML/jackson-modules-java8?tab=readme-ov-file#maven-dependencies
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
