yuxiqian commented on code in PR #3865:
URL: https://github.com/apache/flink-cdc/pull/3865#discussion_r1921739476
##########
flink-cdc-common/src/main/java/org/apache/flink/cdc/common/utils/SchemaMergingUtils.java:
##########
@@ -169,20 +173,52 @@ public static Schema getLeastCommonSchema(
}
/** Merge compatible schemas. */
- public static Schema getCommonSchema(List<Schema> schemas) {
- if (schemas.isEmpty()) {
- return null;
- } else if (schemas.size() == 1) {
- return schemas.get(0);
+ public static Schema getCommonSchema(LinkedHashSet<Schema> schemas) {
Review Comment:
This is a breaking API change since the parameter type constraints are
getting stricter. I think changing List => Collection is acceptable since it's
getting wider.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
