gustavodemorais commented on code in PR #26022:
URL: https://github.com/apache/flink/pull/26022#discussion_r1931805263
##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/BuiltInFunctionDefinitions.java:
##########
@@ -2819,6 +2819,15 @@ ANY, and(logical(LogicalTypeRoot.BOOLEAN), LITERAL)
.runtimeDeferred()
.build();
+ public static final BuiltInFunctionDefinition JSON =
+ BuiltInFunctionDefinition.newBuilder()
+ .name("JSON")
+ .kind(SCALAR)
+
.inputTypeStrategy(sequence(logical(LogicalTypeFamily.CHARACTER_STRING)))
+
.outputTypeStrategy(nullableIfArgs(explicit(DataTypes.STRING())))
+
.runtimeClass("org.apache.flink.table.runtime.functions.scalar.JsonFunction")
Review Comment:
Me neither. Both make _some_ tests fail with ` Unknown call expression:
JSON_OBJECT(NULL, 'K', JSON('{}'))` or similar. I wasn't/am not sure exactly
what was missing by comparing with other funcs as I tried both
deferred/provided. I think we'll need some code related to expression
conversion. I'll take a look again to understand exactly what would be the
difference
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
