[
https://issues.apache.org/jira/browse/FLINK-4821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15747980#comment-15747980
]
ASF GitHub Bot commented on FLINK-4821:
---------------------------------------
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/3001#discussion_r92366382
--- Diff:
flink-connectors/flink-connector-kinesis/src/test/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumerTest.java
---
@@ -377,19 +378,19 @@ public void
testUnparsableLongForAggregationMaxCountInConfig() {
//
----------------------------------------------------------------------
@Test
- public void testSnapshotStateShouldBeNullIfSourceNotOpened() throws
Exception {
+ public void testSnapshotStateShouldBeEmptyListIfSourceNotOpened()
throws Exception {
Properties config = new Properties();
config.setProperty(AWSConfigConstants.AWS_REGION, "us-east-1");
config.setProperty(AWSConfigConstants.AWS_ACCESS_KEY_ID,
"accessKeyId");
config.setProperty(AWSConfigConstants.AWS_SECRET_ACCESS_KEY,
"secretKey");
FlinkKinesisConsumer<String> consumer = new
FlinkKinesisConsumer<>("fakeStream", new SimpleStringSchema(), config);
- assertTrue(consumer.snapshotState(123, 123) == null);
//arbitrary checkpoint id and timestamp
+ assertTrue(consumer.snapshotState(123, 123).size() == 0);
//arbitrary checkpoint id and timestamp
--- End diff --
For actual comparisons, it is nice to use `assertEquals`, because it shows
you the actual value is the error message.
> Implement rescalable non-partitioned state for Kinesis Connector
> ----------------------------------------------------------------
>
> Key: FLINK-4821
> URL: https://issues.apache.org/jira/browse/FLINK-4821
> Project: Flink
> Issue Type: New Feature
> Components: Kinesis Connector
> Reporter: Tzu-Li (Gordon) Tai
> Assignee: Wei-Che Wei
> Fix For: 1.2.0
>
>
> FLINK-4379 added the rescalable non-partitioned state feature, along with the
> implementation for the Kafka connector.
> The AWS Kinesis connector will benefit from the feature and should implement
> it too. This ticket tracks progress for this.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
