xuyangzhong commented on PR #25629: URL: https://github.com/apache/flink/pull/25629#issuecomment-2658307357
> > Thanks for this contribution! LGTM overall. I just left some comments. BTW, could you please explain a little why the current ITCases do not cover these cases to expose this bug? > > Thank you for your comments! I'm sorry, I can't find any harness test that sets the window offset. They all use the default offset=0. Could you give me an example of an existing test that might trigger this bug? And the test data in WindowAggregateITCase is too simple. What about adding some source data for WindowAggregateITCase#testEventTimeTumbleWindowWithOffset, testCascadeEventTimeTumbleWindowWithOffset, etc to reproduce this bug and to verify this bugfix? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
