jnh5y commented on code in PR #26196:
URL: https://github.com/apache/flink/pull/26196#discussion_r1974376977
##########
docs/content/docs/dev/table/sourcesSinks.md:
##########
@@ -335,8 +335,8 @@ the `ParallelismProvider` interface.
<td>Enables to write partitioned data in a
<code>DynamicTableSink</code>.</td>
</tr>
<tr>
- <td>{{< gh_link
file="flink-table/flink-table-common/src/main/java/org/apache/flink/table/connector/source/abilities/SupportsBucketing.java"
name="SupportsBucketing" >}}</td>
- <td>Enables bucketing for a <code>DynamicTableSink</code>.</td>
+ <td>{{< gh_link
file="flink-table/flink-table-common/src/main/java/org/apache/flink/table/connector/sink/abilities/SupportsBucketing.java"
name="SupportsBucketing" >}}</td>
+ <td>Enables to write bucketed data into a
<code>DynamicTableSink</code>.</td>
Review Comment:
Good catch. You are correct that my change for adding the
`SupportsBucketing` bit is not precisely consistent. I'd say that all those
should be changed.
I'd suggest working on that in a separate PR. I like the change for the
code link and the change for ALTER. (Since those are clear mistakes.)
Since this PR is for the Chinese translation, maybe it makes sense to leave
this line unchanged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
