yunfengzhou-hub opened a new pull request, #26241:
URL: https://github.com/apache/flink/pull/26241
## What is the purpose of the change
This PR fixes the bug that AsyncWaitOperator might be triggering
mailboxExecutor.execute() after the mailbox has been quiesced in
AsyncWaitOperatorTest.testProcessingTimeRepeatedCompleteUnorderedWithRetry().
## Brief change log
- Trigger AsyncWaitOperator#endInput by calling
testHarness.waitForTaskCompletion() at the end of
AsyncWaitOperatorTest.testProcessingTimeRepeatedCompleteUnorderedWithRetry()
and other test cases with similar testHarness invoking patterns.
## Verifying this change
The bug can first be reproduced locally with the following steps:
1. In IllWrittenOddInputEmptyResultAsyncFunction, change sleep(3) into
sleep(100L * input). This will increase the race condition and the unorderness
between the async executions that triggers this bug.
2. In testProcessingTimeWithRetry, change `testHarness.getOutput().size() <
expectedOutput.size()` into `testHarness.getOutput().size() < 2`, and remove
the following TestHarnessUtil.assertOutputEqualsSorted() invocation. This helps
the test case reaches the testHarness.close() earlier and increase the
possibility of the bug.
3. Repeatedly run testProcessingTimeRepeatedCompleteUnorderedWithRetry().
Now there should be a 40% possibility to reproduce the failure described in
FLINK-35810.
Now add back the bugfix codes in this PR, and the test failure won't be
reproduced anymore.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
