[ 
https://issues.apache.org/jira/browse/FLINK-37435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17933736#comment-17933736
 ] 

Gyula Fora edited comment on FLINK-37435 at 3/10/25 6:53 AM:
-------------------------------------------------------------

[~kurto] , since only reading (through the Flink KryoSerializer) seems to be 
slower could it be that it is caused by your changes to the *NoFetchingInput* 
class?

There is definitely an extra array copy there that could be suspicious 
[https://github.com/apache/flink/blob/ef09e1716924d1e6ed64bfc273859f2de979b027/flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/NoFetchingInput.java#L93]


was (Author: gyfora):
[~kurto] , since only reading seems to be slower could it be that it is caused 
by your changes to theĀ *NoFetchingInput* class?

There is definitely an extra array copy there that could be suspicious 
[https://github.com/apache/flink/blob/ef09e1716924d1e6ed64bfc273859f2de979b027/flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/NoFetchingInput.java#L93]

> Kryo related perf regression since March 5th
> --------------------------------------------
>
>                 Key: FLINK-37435
>                 URL: https://issues.apache.org/jira/browse/FLINK-37435
>             Project: Flink
>          Issue Type: Bug
>          Components: API / Type Serialization System, Benchmarks
>    Affects Versions: 2.0.0
>            Reporter: Zakelly Lan
>            Priority: Major
>         Attachments: image-2025-03-07-12-29-54-443.png, 
> profile-results-after.zip, profile-results-before.zip
>
>
> Seems a obvious regression across all java version.
> http://flink-speed.xyz/timeline/?exe=6%2C12%2C13&base=&ben=readKryo&env=3&revs=200&equid=off&quarts=on&extr=on
> http://flink-speed.xyz/timeline/?exe=6%2C12%2C13&base=&ben=serializerKryo&env=3&revs=200&equid=off&quarts=on&extr=on



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to