davidradl commented on code in PR #156:
URL:
https://github.com/apache/flink-connector-jdbc/pull/156#discussion_r1986968037
##########
docs/content/docs/connectors/table/jdbc.md:
##########
@@ -702,7 +708,7 @@ SELECT * FROM given_database.test_table2;
Data Type Mapping
----------------
-Flink supports connect to several databases which uses dialect like MySQL,
Oracle, PostgreSQL, CrateDB, Derby, SQL Server, Db2 and OceanBase. The Derby
dialect usually used for testing purpose. The field data type mappings from
relational databases data types to Flink SQL data types are listed in the
following table, the mapping table can help define JDBC table in Flink easily.
+Flink supports connect to several databases which uses dialect like MySQL,
Oracle, PostgreSQL, CrateDB, Derby, SQL Server, Db2, OceanBase and Spanner. The
Derby dialect usually used for testing purpose. The field data type mappings
from relational databases data types to Flink SQL data types are listed in the
following table, the mapping table can help define JDBC table in Flink easily.
Review Comment:
nits:
connect -> the connection
which uses dialect like -> using dialects e.g.
The Derby dialect usually used for testing purpose. -> The Derby dialect is
usually used for testing purpose.
JDBC table -> a JDBC table
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
